Fix Pages deploy: pin Jupyter Book to v1, modernize workflows - #117
Merged
Conversation
The deploy workflow silently stopped publishing the docs site. jupyter-book was unpinned in the docs extra, so it resolved to v2.x -- a MyST-engine rewrite that cannot build this repo's classic _config.yml / _toc.yml book. Under v2, `jupyter-book build jupyterbook` reads the directory as a file, errors, and still exits 0, so the build step went green while producing no HTML. - Pin jupyter-book<2 and drop the unused furo/nbsphinx/sphinx-copybutton from the docs extra; relock (jupyter-book 2.1.4 -> 1.0.4.post1). - Replace peaceiris/actions-gh-pages (no Node 24 release) with the official actions/upload-pages-artifact + actions/deploy-pages. - Bump actions/checkout v4 -> v6 and astral-sh/setup-uv v3 -> v8.1.0 in both workflows, clearing the Node 20 deprecation and the silently-ignored python-version input. - Add a build-output guard so an empty build fails loudly. ghp-import and the Makefile publish-docs target are now redundant but left in place; they will be removed in a follow-up once this is verified live. Deploying requires a one-time repo setting: Settings -> Pages -> Source = "GitHub Actions".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy workflow silently stopped publishing the docs site. jupyter-book was unpinned in the docs extra, so it resolved to v2.x -- a MyST-engine rewrite that cannot build this repo's classic _config.yml / _toc.yml book. Under v2,
jupyter-book build jupyterbookreads the directory as a file, errors, and still exits 0, so the build step went green while producing no HTML.ghp-import and the Makefile publish-docs target are now redundant but left in place; they will be removed in a follow-up once this is verified live.